Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional wait variance #986

Merged
merged 12 commits into from
Oct 25, 2024
Merged

Added optional wait variance #986

merged 12 commits into from
Oct 25, 2024

Conversation

sezanzeb
Copy link
Owner

Finalizing #967

shawarden and others added 12 commits October 7, 2024 08:40
Added an optional argument to wait to the amount of time wait can vary between between the 2 specific values. 2nd 'vary' argument is ignored if value is less than 1st 'time' argument. This more closely resembles the wiki's description of wait as having a range value.
Removed redundant _resolve calls in task and renamed `vary` variable to max_time so it makes more sense.
moved resolver into task so that changes in incoming values are respected
Shortcircuit optional argument comparison to ignore if not specified to be more consistent with other optional arguments.
Forgot to check is max_time is int or None
Added testing of `wait` function.
Crude wait testing as we're rapidly reaching my limits in python vs the time I have for this.
# Conflicts:
#	inputremapper/injection/macros/macro.py
@sezanzeb sezanzeb marked this pull request as ready for review October 25, 2024 20:55
@sezanzeb sezanzeb merged commit 7c4ecf3 into main Oct 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants